Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable retrieval of service logs (via API) #1515

Merged
merged 8 commits into from
Oct 31, 2024
Merged

feat: enable retrieval of service logs (via API) #1515

merged 8 commits into from
Oct 31, 2024

Conversation

RobPasMue
Copy link
Member

@RobPasMue RobPasMue commented Oct 28, 2024 •
edited
Loading

Description

Allows for the retrieval of the service logs when requested (programatically)

Issue linked

Closes #1514

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Oct 28, 2024
@RobPasMue RobPasMue requested a review from a team as a code owner October 28, 2024 10:15
@RobPasMue
Copy link
Member Author

Seems like the API existed but it is not working properly...

@github-actions github-actions bot added the enhancement New features or code improvements label Oct 28, 2024
@RobPasMue RobPasMue mentioned this pull request Oct 29, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Oct 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.69%. Comparing base (07b3f54) to head (aeb289f).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1515      +/-   ##
==========================================
+ Coverage   91.66%   91.69%   +0.02%     
==========================================
  Files          86       86              
  Lines        7018     7043      +25     
==========================================
+ Hits         6433     6458      +25     
  Misses        585      585

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

b-matteo
b-matteo approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@b-matteo b-matteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @RobPasMue for wrapping this up

@RobPasMue RobPasMue merged commit 8854616 into main Oct 31, 2024
40 checks passed
@RobPasMue RobPasMue deleted the feat/retrieve-service-logs branch October 31, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-matteo b-matteo b-matteo approved these changes

Assignees

@RobPasMue RobPasMue

Labels
enhancement New features or code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement API to extract server logs easily from GRPCClient/Modeler
3 participants
@RobPasMue @b-matteo @pyansys-ci-bot